Discussion:
[mkgmap-dev] [Patch v1] unit tests
Gerd Petermann
2015-08-31 05:57:43 UTC
Permalink
Hi Steve,

please review the attached patch.
It fixes two small problems in the unit tests:
1) an osmmap.img was remaining
2) a file args was not closed and produced this error message:
[junit] Running uk.me.parabola.mkgmap.CommandArgsTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 0,071 sec
[junit] Exception in thread "Thread-1" java.lang.AssertionError: delete existing file: args
[junit] at org.junit.Assert.fail(Assert.java:88)
[junit] at org.junit.Assert.assertTrue(Assert.java:41)
[junit] at func.lib.TestUtils.deleteOutputFiles(TestUtils.java:75)
[junit] at func.lib.TestUtils$1.run(TestUtils.java:59)
[junit] at java.lang.Thread.run(Thread.java:745)

Gerd
Steve Ratcliffe
2015-08-31 11:20:39 UTC
Permalink
Hi Gerd
Post by Gerd Petermann
please review the attached patch.
Thanks, looks good to me.

The semi-colons in the try clauses are unnecessary though.

Cheers,
..Steve

Loading...