Discussion:
[mkgmap-dev] [patch v1] don't route the highway=construction ways
Gerd Petermann
2015-10-14 10:02:23 UTC
Permalink
Hi all,

attached patch implements the new internal tag
mkgmap:add-to-NOD=false
to handle the issue discussed here:
http://gis.19327.n5.nabble.com/don-t-route-through-highway-construction-tt5856734.html

It shows how to use it in the default style.
I've also added a rule to ignore highway=planned like highway=proposed

If you don't like the rather technical name mkgmap:add-to-NOD, please let me know it,
here are my ideas for alternatives:
mkgmap:ignore-for-routing=yes
mkgmap:routable=no
mkgmap:address-search-only=yes

Gerd
Gerd Petermann
2015-10-14 10:04:57 UTC
Permalink
sorry, forgot to mention that GPSMapEdit seems to have a problem with
these roads. It shows the road as routable with more or less unpredictable
attributes. But Garmin software seems to work fine.

Gerd

From: ***@hotmail.com
To: mkgmap-***@lists.mkgmap.org.uk
Date: Wed, 14 Oct 2015 12:02:23 +0200
Subject: [mkgmap-dev] [patch v1] don't route the highway=construction ways




Hi all,

attached patch implements the new internal tag
mkgmap:add-to-NOD=false
to handle the issue discussed here:
http://gis.19327.n5.nabble.com/don-t-route-through-highway-construction-tt5856734.html

It shows how to use it in the default style.
I've also added a rule to ignore highway=planned like highway=proposed

If you don't like the rather technical name mkgmap:add-to-NOD, please let me know it,
here are my ideas for alternatives:
mkgmap:ignore-for-routing=yes
mkgmap:routable=no
mkgmap:address-search-only=yes

Gerd
Ben Konrath
2015-10-16 17:52:20 UTC
Permalink
Hi Gerd,

Thanks for creating this patch. I ran a build with the patch and everything
seemed work fine. I installed the map into BaseCamp without problems. I
didn't specifically test a highway=construction way though.

As for the option name, using something like
'mkgmap:ignore-for-routing=yes' would be better because it makes the option
easier to understand at a glance for people, such as myself, who don't know
the nomenclature of the Garmin map format.

Thanks, Ben

On Wed, Oct 14, 2015 at 12:04 PM, Gerd Petermann <
***@hotmail.com> wrote:

> sorry, forgot to mention that GPSMapEdit seems to have a problem with
> these roads. It shows the road as routable with more or less unpredictable
> attributes. But Garmin software seems to work fine.
>
> Gerd
>
> ------------------------------
> From: ***@hotmail.com
> To: mkgmap-***@lists.mkgmap.org.uk
> Date: Wed, 14 Oct 2015 12:02:23 +0200
> Subject: [mkgmap-dev] [patch v1] don't route the highway=construction ways
>
>
> Hi all,
>
> attached patch implements the new internal tag
> mkgmap:add-to-NOD=false
> to handle the issue discussed here:
>
> http://gis.19327.n5.nabble.com/don-t-route-through-highway-construction-tt5856734.html
>
> It shows how to use it in the default style.
> I've also added a rule to ignore highway=planned like highway=proposed
>
> If you don't like the rather technical name mkgmap:add-to-NOD, please let
> me know it,
> here are my ideas for alternatives:
> mkgmap:ignore-for-routing=yes
> mkgmap:routable=no
> mkgmap:address-search-only=yes
>
> Gerd
>
> _______________________________________________ mkgmap-dev mailing list
> mkgmap-***@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-***@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>
Gerd Petermann
2015-10-16 18:05:16 UTC
Permalink
Hi Ben,


thanks for the feedback. I also think that mkgmap:ignore-for-routing=yes is better.


Gerd


________________________________
Von: mkgmap-dev-***@lists.mkgmap.org.uk <mkgmap-dev-***@lists.mkgmap.org.uk> im Auftrag von Ben Konrath <***@bagu.org>
Gesendet: Freitag, 16. Oktober 2015 19:52
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways

Hi Gerd,

Thanks for creating this patch. I ran a build with the patch and everything seemed work fine. I installed the map into BaseCamp without problems. I didn't specifically test a highway=construction way though.

As for the option name, using something like 'mkgmap:ignore-for-routing=yes' would be better because it makes the option easier to understand at a glance for people, such as myself, who don't know the nomenclature of the Garmin map format.

Thanks, Ben

On Wed, Oct 14, 2015 at 12:04 PM, Gerd Petermann <***@hotmail.com<mailto:***@hotmail.com>> wrote:
sorry, forgot to mention that GPSMapEdit seems to have a problem with
these roads. It shows the road as routable with more or less unpredictable
attributes. But Garmin software seems to work fine.

Gerd

________________________________
From: ***@hotmail.com<mailto:***@hotmail.com>
To: mkgmap-***@lists.mkgmap.org.uk<mailto:mkgmap-***@lists.mkgmap.org.uk>
Date: Wed, 14 Oct 2015 12:02:23 +0200
Subject: [mkgmap-dev] [patch v1] don't route the highway=construction ways


Hi all,

attached patch implements the new internal tag
mkgmap:add-to-NOD=false
to handle the issue discussed here:
http://gis.19327.n5.nabble.com/don-t-route-through-highway-construction-tt5856734.html

It shows how to use it in the default style.
I've also added a rule to ignore highway=planned like highway=proposed

If you don't like the rather technical name mkgmap:add-to-NOD, please let me know it,
here are my ideas for alternatives:
mkgmap:ignore-for-routing=yes
mkgmap:routable=no
mkgmap:address-search-only=yes

Gerd

_______________________________________________ mkgmap-dev mailing list mkgmap-***@lists.mkgmap.org.uk<mailto:mkgmap-***@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Alexandre Loss
2015-10-16 18:46:49 UTC
Permalink
I agree also that "mkgmap:ignore-for-routing=yes" is more clear.

2015-10-16 15:05 GMT-03:00 Gerd Petermann <***@hotmail.com>:

> Hi Ben,
>
>
> thanks for the feedback. I also think that mkgmap:ignore-for-routing=yes
> is better.
>
>
> Gerd
>
>
> ------------------------------
> *Von:* mkgmap-dev-***@lists.mkgmap.org.uk <
> mkgmap-dev-***@lists.mkgmap.org.uk> im Auftrag von Ben Konrath <
> ***@bagu.org>
> *Gesendet:* Freitag, 16. Oktober 2015 19:52
> *An:* Development list for mkgmap
> *Betreff:* Re: [mkgmap-dev] [patch v1] don't route the
> highway=construction ways
>
> Hi Gerd,
>
> Thanks for creating this patch. I ran a build with the patch and
> everything seemed work fine. I installed the map into BaseCamp without
> problems. I didn't specifically test a highway=construction way though.
>
> As for the option name, using something like
> 'mkgmap:ignore-for-routing=yes' would be better because it makes the option
> easier to understand at a glance for people, such as myself, who don't know
> the nomenclature of the Garmin map format.
>
> Thanks, Ben
>
> On Wed, Oct 14, 2015 at 12:04 PM, Gerd Petermann <
> ***@hotmail.com> wrote:
>
>> sorry, forgot to mention that GPSMapEdit seems to have a problem with
>> these roads. It shows the road as routable with more or less unpredictable
>> attributes. But Garmin software seems to work fine.
>>
>> Gerd
>>
>> ------------------------------
>> From: ***@hotmail.com
>> To: mkgmap-***@lists.mkgmap.org.uk
>> Date: Wed, 14 Oct 2015 12:02:23 +0200
>> Subject: [mkgmap-dev] [patch v1] don't route the highway=construction
>> ways
>>
>>
>> Hi all,
>>
>> attached patch implements the new internal tag
>> mkgmap:add-to-NOD=false
>> to handle the issue discussed here:
>>
>> http://gis.19327.n5.nabble.com/don-t-route-through-highway-construction-tt5856734.html
>>
>> It shows how to use it in the default style.
>> I've also added a rule to ignore highway=planned like highway=proposed
>>
>> If you don't like the rather technical name mkgmap:add-to-NOD, please let
>> me know it,
>> here are my ideas for alternatives:
>> mkgmap:ignore-for-routing=yes
>> mkgmap:routable=no
>> mkgmap:address-search-only=yes
>>
>> Gerd
>>
>> _______________________________________________ mkgmap-dev mailing list
>> mkgmap-***@lists.mkgmap.org.uk
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>
>> _______________________________________________
>> mkgmap-dev mailing list
>> mkgmap-***@lists.mkgmap.org.uk
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>
>
>
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-***@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>
Mike Baggaley
2015-10-16 19:12:14 UTC
Permalink
How about mkgmap:non-routable=yes ?



However, I don’t quite understand the reason behind the concept – surely if the road is under construction you can just set the type to be a non-routable one. If you are reusing a routable type, but telling the device not to allow routing down it, there will be scratched heads when you can’t route along a road that looks no different to any other.



Regards,

Mike



From: Alexandre Loss [mailto:***@gmail.com]
Sent: 16 October 2015 19:47
To: Development list for mkgmap <mkgmap-***@lists.mkgmap.org.uk>
Subject: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways



I agree also that "mkgmap:ignore-for-routing=yes" is more clear.



2015-10-16 15:05 GMT-03:00 Gerd Petermann <***@hotmail.com <mailto:***@hotmail.com> >:

Hi Ben,



thanks for the feedback. I also think that mkgmap:ignore-for-routing=yes is better.



Gerd




_____


Von: mkgmap-dev-***@lists.mkgmap.org.uk <mailto:mkgmap-dev-***@lists.mkgmap.org.uk> <mkgmap-dev-***@lists.mkgmap.org.uk <mailto:mkgmap-dev-***@lists.mkgmap.org.uk> > im Auftrag von Ben Konrath <***@bagu.org <mailto:***@bagu.org> >
Gesendet: Freitag, 16. Oktober 2015 19:52
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways



Hi Gerd,

Thanks for creating this patch. I ran a build with the patch and everything seemed work fine. I installed the map into BaseCamp without problems. I didn't specifically test a highway=construction way though.

As for the option name, using something like 'mkgmap:ignore-for-routing=yes' would be better because it makes the option easier to understand at a glance for people, such as myself, who don't know the nomenclature of the Garmin map format.

Thanks, Ben



On Wed, Oct 14, 2015 at 12:04 PM, Gerd Petermann <***@hotmail.com <mailto:***@hotmail.com> > wrote:

sorry, forgot to mention that GPSMapEdit seems to have a problem with
these roads. It shows the road as routable with more or less unpredictable
attributes. But Garmin software seems to work fine.

Gerd


_____


From: ***@hotmail.com <mailto:***@hotmail.com>
To: mkgmap-***@lists.mkgmap.org.uk <mailto:mkgmap-***@lists.mkgmap.org.uk>
Date: Wed, 14 Oct 2015 12:02:23 +0200
Subject: [mkgmap-dev] [patch v1] don't route the highway=construction ways



Hi all,

attached patch implements the new internal tag
mkgmap:add-to-NOD=false
to handle the issue discussed here:
http://gis.19327.n5.nabble.com/don-t-route-through-highway-construction-tt5856734.html

It shows how to use it in the default style.
I've also added a rule to ignore highway=planned like highway=proposed

If you don't like the rather technical name mkgmap:add-to-NOD, please let me know it,
here are my ideas for alternatives:
mkgmap:ignore-for-routing=yes
mkgmap:routable=no
mkgmap:address-search-only=yes

Gerd



_______________________________________________ mkgmap-dev mailing list mkgmap-***@lists.mkgmap.org.uk <mailto:mkgmap-***@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Gerd Petermann
2015-10-19 04:38:21 UTC
Permalink
Hi Mike,


good points. My thinking was that we need a routable type when we still want to be able to assign

addresses (addr:housenumber) to the way. AFAIK we have no way to mark such a road as special in

the map without a typ file ?

Gerd
________________________________
Von: mkgmap-dev-***@lists.mkgmap.org.uk <mkgmap-dev-***@lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <***@tvage.co.uk>
Gesendet: Freitag, 16. Oktober 2015 21:12
An: 'Development list for mkgmap'
Betreff: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways


How about mkgmap:non-routable=yes ?



However, I don't quite understand the reason behind the concept - surely if the road is under construction you can just set the type to be a non-routable one. If you are reusing a routable type, but telling the device not to allow routing down it, there will be scratched heads when you can't route along a road that looks no different to any other.



Regards,

Mike



From: Alexandre Loss [mailto:***@gmail.com]
Sent: 16 October 2015 19:47
To: Development list for mkgmap <mkgmap-***@lists.mkgmap.org.uk>
Subject: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways



I agree also that "mkgmap:ignore-for-routing=yes" is more clear.



2015-10-16 15:05 GMT-03:00 Gerd Petermann <***@hotmail.com<mailto:***@hotmail.com>>:

Hi Ben,



thanks for the feedback. I also think that mkgmap:ignore-for-routing=yes is better.



Gerd



________________________________

Von: mkgmap-dev-***@lists.mkgmap.org.uk<mailto:mkgmap-dev-***@lists.mkgmap.org.uk> <mkgmap-dev-***@lists.mkgmap.org.uk<mailto:mkgmap-dev-***@lists.mkgmap.org.uk>> im Auftrag von Ben Konrath <***@bagu.org<mailto:***@bagu.org>>
Gesendet: Freitag, 16. Oktober 2015 19:52
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways



Hi Gerd,

Thanks for creating this patch. I ran a build with the patch and everything seemed work fine. I installed the map into BaseCamp without problems. I didn't specifically test a highway=construction way though.

As for the option name, using something like 'mkgmap:ignore-for-routing=yes' would be better because it makes the option easier to understand at a glance for people, such as myself, who don't know the nomenclature of the Garmin map format.

Thanks, Ben



On Wed, Oct 14, 2015 at 12:04 PM, Gerd Petermann <***@hotmail.com<mailto:***@hotmail.com>> wrote:

sorry, forgot to mention that GPSMapEdit seems to have a problem with
these roads. It shows the road as routable with more or less unpredictable
attributes. But Garmin software seems to work fine.

Gerd

________________________________

From: ***@hotmail.com<mailto:***@hotmail.com>
To: mkgmap-***@lists.mkgmap.org.uk<mailto:mkgmap-***@lists.mkgmap.org.uk>
Date: Wed, 14 Oct 2015 12:02:23 +0200
Subject: [mkgmap-dev] [patch v1] don't route the highway=construction ways



Hi all,

attached patch implements the new internal tag
mkgmap:add-to-NOD=false
to handle the issue discussed here:
http://gis.19327.n5.nabble.com/don-t-route-through-highway-construction-tt5856734.html

It shows how to use it in the default style.
I've also added a rule to ignore highway=planned like highway=proposed

If you don't like the rather technical name mkgmap:add-to-NOD, please let me know it,
here are my ideas for alternatives:
mkgmap:ignore-for-routing=yes
mkgmap:routable=no
mkgmap:address-search-only=yes

Gerd



_______________________________________________ mkgmap-dev mailing list mkgmap-***@lists.mkgmap.org.uk<mailto:mkgmap-***@lists.mkgmap.org.uk> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Andrzej Popowski
2015-10-19 11:37:24 UTC
Permalink
Hi,


I guess Garmin img format allows for many non-standard solutions, but I
would be afraid to implement them into standard compilation. It could
lead to unexpected problems, difficult to trace. My last experience with
using routable lines as no-routable objects for addressing is following:
- routing in Mapsource works correctly,
- routing in latest BaseCamp works for motocycle, hiking, bicycle etc.,
- routing in latest BaseCamp doesn't work for car.

This was cGPSmapper compilation, I haven't tested mkgmap outcome.

--
Best regards,
Andrzej
Gerd Petermann
2015-10-19 12:01:45 UTC
Permalink
Hi Andrzej,

I am not sure what you did and what "routing doesn't work" means
in this case.

Gerd

________________________________________
Von: mkgmap-dev-***@lists.mkgmap.org.uk <mkgmap-dev-***@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <***@poczta.onet.pl>
Gesendet: Montag, 19. Oktober 2015 13:37
An: mkgmap-***@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways

Hi,


I guess Garmin img format allows for many non-standard solutions, but I
would be afraid to implement them into standard compilation. It could
lead to unexpected problems, difficult to trace. My last experience with
using routable lines as no-routable objects for addressing is following:
- routing in Mapsource works correctly,
- routing in latest BaseCamp works for motocycle, hiking, bicycle etc.,
- routing in latest BaseCamp doesn't work for car.

This was cGPSmapper compilation, I haven't tested mkgmap outcome.

--
Best regards,
Andrzej
Andrzej Popowski
2015-10-19 14:12:24 UTC
Permalink
Hi Gerd,

> I am not sure what you did and what "routing doesn't work" means
> in this case.

My map was similar to the experiments, that you have analyzed here:
http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2015q2/023244.html

Only I have added relatively small number of non-routable lines with
address. This worked correctly until recent releases of BaseCamp, where
I get direct routes (straight lines) instead of routes following roads.
Problem appears only for "driving" activity (car). When I change
activity to "motorcycling" or "trucking", recalculation gives proper
routing on roads.

I'm not sure if current topic cold lead to similar problems, but I'm
cautious about mixing routable/no-routable roads in a single map.

--
Best regards,
Andrzej
Gerd Petermann
2015-10-19 14:19:03 UTC
Permalink
Hi Andrzej,

still not sure what you mean. The patch implements a way to have a line
with a routable type that appears in NET but not in NOD. In other words,
the NET file doesn't contain a pointer into NOD. Do you think that this breaks
routing? Or do you refer to possible alternative solutions?

Gerd

________________________________________
Von: mkgmap-dev-***@lists.mkgmap.org.uk <mkgmap-dev-***@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <***@poczta.onet.pl>
Gesendet: Montag, 19. Oktober 2015 16:12
An: mkgmap-***@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways

Hi Gerd,

> I am not sure what you did and what "routing doesn't work" means
> in this case.

My map was similar to the experiments, that you have analyzed here:
http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2015q2/023244.html

Only I have added relatively small number of non-routable lines with
address. This worked correctly until recent releases of BaseCamp, where
I get direct routes (straight lines) instead of routes following roads.
Problem appears only for "driving" activity (car). When I change
activity to "motorcycling" or "trucking", recalculation gives proper
routing on roads.

I'm not sure if current topic cold lead to similar problems, but I'm
cautious about mixing routable/no-routable roads in a single map.

--
Best regards,
Andrzej
Andrzej Popowski
2015-10-19 22:44:43 UTC
Permalink
Hi Gerd,

> The patch implements a way to have a line
> with a routable type that appears in NET but not in NOD.
> In other words, the NET file doesn't contain a pointer into NOD.

I only express concern, that it could break routing, because it looks
like a quite non-standard approach.

--
Best regards,
Andrzej
Gerd Petermann
2015-10-20 06:15:46 UTC
Permalink
Hi Andrzej,

okay, I see. I've implemented parts of the code to support a map
containing NET without NOD file, I am not sure if Garmin
maps also use the corresponding flags to disable routing on selected
roads. If that is not the case I agree that we should try to find another
solution.

Gerd



________________________________________
Von: mkgmap-dev-***@lists.mkgmap.org.uk <mkgmap-dev-***@lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <***@poczta.onet.pl>
Gesendet: Dienstag, 20. Oktober 2015 00:44
An: mkgmap-***@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways

Hi Gerd,

> The patch implements a way to have a line
> with a routable type that appears in NET but not in NOD.
> In other words, the NET file doesn't contain a pointer into NOD.

I only express concern, that it could break routing, because it looks
like a quite non-standard approach.

--
Best regards,
Andrzej
chris66
2015-10-20 08:52:21 UTC
Permalink
Am 16.10.2015 um 20:46 schrieb Alexandre Loss:
> I agree also that "mkgmap:ignore-for-routing=yes" is more clear.

I used this tag already in OSM to mark isolated ways. :-)

https://www.openstreetmap.org/way/111674198#map=18/54.3354/8.5915

Chris
Gerd Petermann
2015-10-20 09:38:41 UTC
Permalink
Hi Chris,
glad to see that you did not use the mkgmap: prefix ;-)

Gerd

________________________________________
Von: mkgmap-dev-***@lists.mkgmap.org.uk <mkgmap-dev-***@lists.mkgmap.org.uk> im Auftrag von chris66 <***@gmx.de>
Gesendet: Dienstag, 20. Oktober 2015 10:52
An: mkgmap-***@lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways

Am 16.10.2015 um 20:46 schrieb Alexandre Loss:
> I agree also that "mkgmap:ignore-for-routing=yes" is more clear.

I used this tag already in OSM to mark isolated ways. :-)

https://www.openstreetmap.org/way/111674198#map=18/54.3354/8.5915

Chris
Ben Konrath
2015-10-21 07:28:49 UTC
Permalink
For people who have issues with Gerd's implement (line is in NET but not in
NOD): What do you think about my original suggestion of adding "setaccess
'no';" to highway=construction?

Thanks, Ben

On Tue, Oct 20, 2015 at 11:38 AM, Gerd Petermann <
***@hotmail.com> wrote:

> Hi Chris,
> glad to see that you did not use the mkgmap: prefix ;-)
>
> Gerd
>
> ________________________________________
> Von: mkgmap-dev-***@lists.mkgmap.org.uk <
> mkgmap-dev-***@lists.mkgmap.org.uk> im Auftrag von chris66 <
> ***@gmx.de>
> Gesendet: Dienstag, 20. Oktober 2015 10:52
> An: mkgmap-***@lists.mkgmap.org.uk
> Betreff: Re: [mkgmap-dev] [patch v1] don't route the highway=construction
> ways
>
> Am 16.10.2015 um 20:46 schrieb Alexandre Loss:
> > I agree also that "mkgmap:ignore-for-routing=yes" is more clear.
>
> I used this tag already in OSM to mark isolated ways. :-)
>
> https://www.openstreetmap.org/way/111674198#map=18/54.3354/8.5915
>
> Chris
>
>
>
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-***@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-***@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>
Gerd Petermann
2015-10-21 07:44:27 UTC
Permalink
Hi Ben,


I've already mentioned that setaccess no will not work when the way has explicit tags

like bicycle=yes as it only sets the values prefixed with mkgmap:

The rules in inc/access will ignore this bec ause of this block which is evaluated later:

foot=* { set mkgmap:foot='${foot}' }
bicycle=* { set mkgmap:bicycle='${bicycle}' }
motorcar=* { set mkgmap:car='${motorcar}' }
goods=* { set mkgmap:delivery='${goods}' }
hgv=* { set mkgmap:truck='${hgv}' }
bus=* { set mkgmap:bus='${bus}' }
taxi=* { set mkgmap:taxi='${taxi}' }
emergency=* { set mkgmap:emergency='${emergency}' }


I think the docu for the "setaccess no" action is very clear, but its name is very misleading :-(

I think the only intended usage was in the rules which helped to use an old style (inc/compat_lines)


Gerd



________________________________
Von: mkgmap-dev-***@lists.mkgmap.org.uk <mkgmap-dev-***@lists.mkgmap.org.uk> im Auftrag von Ben Konrath <***@bagu.org>
Gesendet: Mittwoch, 21. Oktober 2015 09:28
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways

For people who have issues with Gerd's implement (line is in NET but not in NOD): What do you think about my original suggestion of adding "setaccess 'no';" to highway=construction?

Thanks, Ben

On Tue, Oct 20, 2015 at 11:38 AM, Gerd Petermann <***@hotmail.com<mailto:***@hotmail.com>> wrote:
Hi Chris,
glad to see that you did not use the mkgmap: prefix ;-)

Gerd

________________________________________
Von: mkgmap-dev-***@lists.mkgmap.org.uk<mailto:mkgmap-dev-***@lists.mkgmap.org.uk> <mkgmap-dev-***@lists.mkgmap.org.uk<mailto:mkgmap-dev-***@lists.mkgmap.org.uk>> im Auftrag von chris66 <***@gmx.de<mailto:***@gmx.de>>
Gesendet: Dienstag, 20. Oktober 2015 10:52
An: mkgmap-***@lists.mkgmap.org.uk<mailto:mkgmap-***@lists.mkgmap.org.uk>
Betreff: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways

Am 16.10.2015 um 20:46 schrieb Alexandre Loss:
> I agree also that "mkgmap:ignore-for-routing=yes" is more clear.

I used this tag already in OSM to mark isolated ways. :-)

https://www.openstreetmap.org/way/111674198#map=18/54.3354/8.5915

Chris
Gerd Petermann
2015-10-22 04:54:25 UTC
Permalink
Hi Ben,


attached is my version of your approach. It adds the rule

# Don't route through highway=construction, they are considered unusable
highway=construction {setaccess no}

at the very end of inc/access.

This should work, but splits the special handling of highway=construction.


Gerd


________________________________
Von: mkgmap-dev-***@lists.mkgmap.org.uk <mkgmap-dev-***@lists.mkgmap.org.uk> im Auftrag von Ben Konrath <***@bagu.org>
Gesendet: Mittwoch, 21. Oktober 2015 09:28
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways

For people who have issues with Gerd's implement (line is in NET but not in NOD): What do you think about my original suggestion of adding "setaccess 'no';" to highway=construction?

Thanks, Ben

On Tue, Oct 20, 2015 at 11:38 AM, Gerd Petermann <***@hotmail.com<mailto:***@hotmail.com>> wrote:
Hi Chris,
glad to see that you did not use the mkgmap: prefix ;-)

Gerd

________________________________________
Von: mkgmap-dev-***@lists.mkgmap.org.uk<mailto:mkgmap-dev-***@lists.mkgmap.org.uk> <mkgmap-dev-***@lists.mkgmap.org.uk<mailto:mkgmap-dev-***@lists.mkgmap.org.uk>> im Auftrag von chris66 <***@gmx.de<mailto:***@gmx.de>>
Gesendet: Dienstag, 20. Oktober 2015 10:52
An: mkgmap-***@lists.mkgmap.org.uk<mailto:mkgmap-***@lists.mkgmap.org.uk>
Betreff: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways

Am 16.10.2015 um 20:46 schrieb Alexandre Loss:
> I agree also that "mkgmap:ignore-for-routing=yes" is more clear.

I used this tag already in OSM to mark isolated ways. :-)

https://www.openstreetmap.org/way/111674198#map=18/54.3354/8.5915

Chris
Ben Konrath
2015-10-22 19:30:20 UTC
Permalink
Hi Gerd,

Thanks for the explanation (again) and for the new patch. This approach is
probably better considering the concerns about v1. Perhaps you can add a
comment about this new rule above the highway=construction statement in the
lines file. That way people will be able to find the special handling when
reading the lines file.

Thanks, Ben

On Thu, Oct 22, 2015 at 6:54 AM, Gerd Petermann <
***@hotmail.com> wrote:

> Hi Ben,
>
>
> attached is my version of your approach. It adds the rule
>
> # Don't route through highway=construction, they are considered unusable
> highway=construction {setaccess no}
>
> at the very end of inc/access.
>
> This should work, but splits the special handling of highway=construction.
>
>
> Gerd
>
>
> ------------------------------
> *Von:* mkgmap-dev-***@lists.mkgmap.org.uk <
> mkgmap-dev-***@lists.mkgmap.org.uk> im Auftrag von Ben Konrath <
> ***@bagu.org>
> *Gesendet:* Mittwoch, 21. Oktober 2015 09:28
> *An:* Development list for mkgmap
> *Betreff:* Re: [mkgmap-dev] [patch v1] don't route the
> highway=construction ways
>
> For people who have issues with Gerd's implement (line is in NET but not
> in NOD): What do you think about my original suggestion of adding
> "setaccess 'no';" to highway=construction?
>
> Thanks, Ben
>
> On Tue, Oct 20, 2015 at 11:38 AM, Gerd Petermann <
> ***@hotmail.com> wrote:
>
>> Hi Chris,
>> glad to see that you did not use the mkgmap: prefix ;-)
>>
>> Gerd
>>
>> ________________________________________
>> Von: mkgmap-dev-***@lists.mkgmap.org.uk <
>> mkgmap-dev-***@lists.mkgmap.org.uk> im Auftrag von chris66 <
>> ***@gmx.de>
>> Gesendet: Dienstag, 20. Oktober 2015 10:52
>> An: mkgmap-***@lists.mkgmap.org.uk
>> Betreff: Re: [mkgmap-dev] [patch v1] don't route the
>> highway=construction ways
>>
>> Am 16.10.2015 um 20:46 schrieb Alexandre Loss:
>> > I agree also that "mkgmap:ignore-for-routing=yes" is more clear.
>>
>> I used this tag already in OSM to mark isolated ways. :-)
>>
>> https://www.openstreetmap.org/way/111674198#map=18/54.3354/8.5915
>>
>> Chris
>>
>>
>>
>> _______________________________________________
>> mkgmap-dev mailing list
>> mkgmap-***@lists.mkgmap.org.uk
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>> _______________________________________________
>> mkgmap-dev mailing list
>> mkgmap-***@lists.mkgmap.org.uk
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>
>
>
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-***@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>
Gerd Petermann
2015-10-23 13:01:19 UTC
Permalink
Hi Ben,


okay, I've added a comment, see attached v3.

if I hear no complains I'll commit this patch next monday.


Gerd


________________________________
Von: mkgmap-dev-***@lists.mkgmap.org.uk <mkgmap-dev-***@lists.mkgmap.org.uk> im Auftrag von Ben Konrath <***@bagu.org>
Gesendet: Donnerstag, 22. Oktober 2015 21:30
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways

Hi Gerd,

Thanks for the explanation (again) and for the new patch. This approach is probably better considering the concerns about v1. Perhaps you can add a comment about this new rule above the highway=construction statement in the lines file. That way people will be able to find the special handling when reading the lines file.

Thanks, Ben

On Thu, Oct 22, 2015 at 6:54 AM, Gerd Petermann <***@hotmail.com<mailto:***@hotmail.com>> wrote:

Hi Ben,


attached is my version of your approach. It adds the rule

# Don't route through highway=construction, they are considered unusable
highway=construction {setaccess no}

at the very end of inc/access.

This should work, but splits the special handling of highway=construction.


Gerd


________________________________
Von: mkgmap-dev-***@lists.mkgmap.org.uk<mailto:mkgmap-dev-***@lists.mkgmap.org.uk> <mkgmap-dev-***@lists.mkgmap.org.uk<mailto:mkgmap-dev-***@lists.mkgmap.org.uk>> im Auftrag von Ben Konrath <***@bagu.org<mailto:***@bagu.org>>
Gesendet: Mittwoch, 21. Oktober 2015 09:28
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways

For people who have issues with Gerd's implement (line is in NET but not in NOD): What do you think about my original suggestion of adding "setaccess 'no';" to highway=construction?

Thanks, Ben

On Tue, Oct 20, 2015 at 11:38 AM, Gerd Petermann <***@hotmail.com<mailto:***@hotmail.com>> wrote:
Hi Chris,
glad to see that you did not use the mkgmap: prefix ;-)

Gerd

________________________________________
Von: mkgmap-dev-***@lists.mkgmap.org.uk<mailto:mkgmap-dev-***@lists.mkgmap.org.uk> <mkgmap-dev-***@lists.mkgmap.org.uk<mailto:mkgmap-dev-***@lists.mkgmap.org.uk>> im Auftrag von chris66 <***@gmx.de<mailto:***@gmx.de>>
Gesendet: Dienstag, 20. Oktober 2015 10:52
An: mkgmap-***@lists.mkgmap.org.uk<mailto:mkgmap-***@lists.mkgmap.org.uk>
Betreff: Re: [mkgmap-dev] [patch v1] don't route the highway=construction ways

Am 16.10.2015 um 20:46 schrieb Alexandre Loss:
> I agree also that "mkgmap:ignore-for-routing=yes" is more clear.

I used this tag already in OSM to mark isolated ways. :-)

https://www.openstreetmap.org/way/111674198#map=18/54.3354/8.5915

Chris



_______________________________________________
mkgmap-dev mailing list
mkgmap-***@lists.mkgmap.org.uk<mailto:mkgmap-***@lists.mkgmap.org.uk>
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Loading...