Discussion:
[mkgmap-dev] What's the meaning of the 'has no region' warnings?
Carlos Dávila
2015-08-11 11:50:01 UTC
Permalink
What is supposed to be wrong regarding warnings of type '(MapBuilder):
55114001.o5m: Highway EX-A2 has no region (define a default region to
zap this warning)'
Gerd Petermann
2015-08-12 09:14:22 UTC
Permalink
Hi Carlos,

I am not sure if this is an error in mkgmap or not.

If you do what the message says, e.g. using --region-name=xyz,
the message disappears, but I am not sure about the side
effects and why mkgmap doesn't use a default value.

The message is produced by code that handles motorway-exit nodes,
they are stored in some index structures, I have no idea why.
I guess some devices allow (or allowed) to search for exits?

@Steve: The code was introduced with r984 and it used the default
region to create a label instead of first checking the nodes' region attribute.
I don't understand that.

Gerd


> Date: Tue, 11 Aug 2015 13:50:01 +0200
> From: ***@orangecorreo.es
> To: mkgmap-***@lists.mkgmap.org.uk
> Subject: [mkgmap-dev] What's the meaning of the 'has no region' warnings?
>
> What is supposed to be wrong regarding warnings of type '(MapBuilder):
> 55114001.o5m: Highway EX-A2 has no region (define a default region to
> zap this warning)'
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-***@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Carlos Dávila
2015-08-12 10:17:04 UTC
Permalink
OK, but shouldn't region be set by mkgmap from bounds information?

El 12/08/15 a las 11:14, Gerd Petermann escribió:
> Hi Carlos,
>
> I am not sure if this is an error in mkgmap or not.
>
> If you do what the message says, e.g. using --region-name=xyz,
> the message disappears, but I am not sure about the side
> effects and why mkgmap doesn't use a default value.
>
> The message is produced by code that handles motorway-exit nodes,
> they are stored in some index structures, I have no idea why.
> I guess some devices allow (or allowed) to search for exits?
>
> @Steve: The code was introduced with r984 and it used the default
> region to create a label instead of first checking the nodes' region
> attribute.
> I don't understand that.
>
> Gerd
>
>
> > Date: Tue, 11 Aug 2015 13:50:01 +0200
> > From: ***@orangecorreo.es
> > To: mkgmap-***@lists.mkgmap.org.uk
> > Subject: [mkgmap-dev] What's the meaning of the 'has no region'
> warnings?
> >
> > What is supposed to be wrong regarding warnings of type '(MapBuilder):
> > 55114001.o5m: Highway EX-A2 has no region (define a default region to
> > zap this warning)'
GerdP
2015-08-12 10:27:05 UTC
Permalink
Hi Carlos,

that's exactly the point that I don't understand. When
WanMil added the code for the bounds option
he changed the code around this exit handling a little
bit, but he kept the behaviour regarding the region.

Gerd


Carlos Dávila-2 wrote
> OK, but shouldn't region be set by mkgmap from bounds information?
>
> El 12/08/15 a las 11:14, Gerd Petermann escribió:
>> Hi Carlos,
>>
>> I am not sure if this is an error in mkgmap or not.
>>
>> If you do what the message says, e.g. using --region-name=xyz,
>> the message disappears, but I am not sure about the side
>> effects and why mkgmap doesn't use a default value.
>>
>> The message is produced by code that handles motorway-exit nodes,
>> they are stored in some index structures, I have no idea why.
>> I guess some devices allow (or allowed) to search for exits?
>>
>> @Steve: The code was introduced with r984 and it used the default
>> region to create a label instead of first checking the nodes' region
>> attribute.
>> I don't understand that.
>>
>> Gerd
>>
>>
>> > Date: Tue, 11 Aug 2015 13:50:01 +0200
>> > From:

> cdavilam@

>> > To:

> mkgmap-***@.org

>> > Subject: [mkgmap-dev] What's the meaning of the 'has no region'
>> warnings?
>> >
>> > What is supposed to be wrong regarding warnings of type '(MapBuilder):
>> > 55114001.o5m: Highway EX-A2 has no region (define a default region to
>> > zap this warning)'
>
> _______________________________________________
> mkgmap-dev mailing list

> mkgmap-***@.org

> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev





--
View this message in context: http://gis.19327.n5.nabble.com/What-s-the-meaning-of-the-has-no-region-warnings-tp5852093p5852170.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.
Steve Ratcliffe
2015-08-12 22:08:26 UTC
Permalink
Hi Gerd

> @Steve: The code was introduced with r984 and it used the default
> region to create a label instead of first checking the nodes' region
> attribute.
> I don't understand that.

This was before the bounds file, and I would think that there would
have been close to zero chance that any exit nodes would have
had a region tag in OSM at that time.

So I guess it was just not important at the time. I certainly don't
recall any reason for it.

..Steve
Gerd Petermann
2015-08-13 05:29:27 UTC
Permalink
Hi Steve,

attached is a patch to use the nodes' region.
Please check: If I got that right, mkgmap collects and writes
the exists for each highway, so I wonder what should happen
when the input file contains two different highways
with the same ref (maybe A1).

I have no idea where the highway/exit info is used, so
I don't know how to test the effect.

Gerd

> To: mkgmap-***@lists.mkgmap.org.uk
> From: ***@parabola.me.uk
> Date: Wed, 12 Aug 2015 23:08:26 +0100
> Subject: Re: [mkgmap-dev] What's the meaning of the 'has no region' warnings?
>
>
> Hi Gerd
>
> > @Steve: The code was introduced with r984 and it used the default
> > region to create a label instead of first checking the nodes' region
> > attribute.
> > I don't understand that.
>
> This was before the bounds file, and I would think that there would
> have been close to zero chance that any exit nodes would have
> had a region tag in OSM at that time.
>
> So I guess it was just not important at the time. I certainly don't
> recall any reason for it.
>
> ..Steve
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-***@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Carlos Dávila
2015-08-18 19:14:49 UTC
Permalink
Regarding your patch I just can say that it zaps the warnings. I don't
have any idea of other effects it may have either.

El 13/08/15 a las 07:29, Gerd Petermann escribió:
> Hi Steve,
>
> attached is a patch to use the nodes' region.
> Please check: If I got that right, mkgmap collects and writes
> the exists for each highway, so I wonder what should happen
> when the input file contains two different highways
> with the same ref (maybe A1).
>
> I have no idea where the highway/exit info is used, so
> I don't know how to test the effect.
>
> Gerd
>
> > To: mkgmap-***@lists.mkgmap.org.uk
> > From: ***@parabola.me.uk
> > Date: Wed, 12 Aug 2015 23:08:26 +0100
> > Subject: Re: [mkgmap-dev] What's the meaning of the 'has no region'
> warnings?
> >
> >
> > Hi Gerd
> >
> > > @Steve: The code was introduced with r984 and it used the default
> > > region to create a label instead of first checking the nodes' region
> > > attribute.
> > > I don't understand that.
> >
> > This was before the bounds file, and I would think that there would
> > have been close to zero chance that any exit nodes would have
> > had a region tag in OSM at that time.
> >
> > So I guess it was just not important at the time. I certainly don't
> > recall any reason for it.
> >
> > ..Steve
Gerd Petermann
2015-08-19 07:32:49 UTC
Permalink
Hi all,

I hesitate to commit this patch because I think that we
probably can remove the code instead of "fixing" it.

I found this in imgformat-1.0.pdf:

Highway Records, Exit Records and Highway Data Records
These records were apparently used by the old Roads and Recreation maps to describe services
available at various highway exits, rest areas and so on
In mkgmap we have code to write these records, and this code prints the "has no region" warning.

I still have no idea where the data is used. Maybe the device shows some additional
info when you drive on a motorway.
When Mark Burton committed the code with r984 he did not describe the wanted effect,
but he also seemed to be unsure about its positive effects, see here:
http://www.mkgmap.org.uk/websvn/listing.php?repname=mkgmap&rev=984

and here:
http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2009q1/001293.html

I don't know if the problems regarding the basemap were solved later, but
my Oregon 600 doesn't seem to allow to search for exits at alll. Maybe I have to
enable/disable an option for this.

Does anybody know more?

Gerd


> Date: Tue, 18 Aug 2015 21:14:49 +0200
> From: ***@orangecorreo.es
> To: mkgmap-***@lists.mkgmap.org.uk
> Subject: Re: [mkgmap-dev] What's the meaning of the 'has no region' warnings?
>
> Regarding your patch I just can say that it zaps the warnings. I don't
> have any idea of other effects it may have either.
>
> El 13/08/15 a las 07:29, Gerd Petermann escribió:
> > Hi Steve,
> >
> > attached is a patch to use the nodes' region.
> > Please check: If I got that right, mkgmap collects and writes
> > the exists for each highway, so I wonder what should happen
> > when the input file contains two different highways
> > with the same ref (maybe A1).
> >
> > I have no idea where the highway/exit info is used, so
> > I don't know how to test the effect.
> >
> > Gerd
> >
> > > To: mkgmap-***@lists.mkgmap.org.uk
> > > From: ***@parabola.me.uk
> > > Date: Wed, 12 Aug 2015 23:08:26 +0100
> > > Subject: Re: [mkgmap-dev] What's the meaning of the 'has no region'
> > warnings?
> > >
> > >
> > > Hi Gerd
> > >
> > > > @Steve: The code was introduced with r984 and it used the default
> > > > region to create a label instead of first checking the nodes' region
> > > > attribute.
> > > > I don't understand that.
> > >
> > > This was before the bounds file, and I would think that there would
> > > have been close to zero chance that any exit nodes would have
> > > had a region tag in OSM at that time.
> > >
> > > So I guess it was just not important at the time. I certainly don't
> > > recall any reason for it.
> > >
> > > ..Steve
>
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-***@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Thorsten Kukuk
2015-08-19 10:04:41 UTC
Permalink
Hi,

On Wed, Aug 19, Gerd Petermann wrote:

> I still have no idea where the data is used. Maybe the device shows some additional
> info when you drive on a motorway.
> When Mark Burton committed the code with r984 he did not describe the wanted effect,
> but he also seemed to be unsure about its positive effects, see here:
> http://www.mkgmap.org.uk/websvn/listing.php?repname=mkgmap&rev=984
>
> and here:
> http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2009q1/001293.html

It looks like this is the code responsible for exit:to and similar variables.
I played with this some time ago and the informations are shown in mapsource,
don't remember anymore about my GPS device.
The problem is, with the current way how things are mapped
in OSM, it is nearly impossible to fill out this fields correct
only with a style file. This would need help of mkgmap itself.
That's why I stopped looking at it.

But I haven't found a way to search for them, too.

In the end, I would let the code stay and not remove it.

Thorsten

--
Thorsten Kukuk, Senior Architect SLES & Common Code Base
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
Gerd Petermann
2015-08-24 06:14:23 UTC
Permalink
Hi Thorsten,

If I got that right we are talking about two different things.
The code that handles the exit:to and similar variables would stay,
means, the possibility to add infos to an exit node would still
work although nobody seems to use it.
I am talking about the code that adds the exit nodes to special
sections in the index and LBL file (e.g. LBL9 + LBL10).
I think that this info in the img and the corresponding code is obsolete.

My problem: The talks in year 2009 / 2010 suggest that it was possible to search
for exits at that time but that the search always used the basemap that came with
the device. One possible explanation for the - now missing - search is that the
Garmin software was faulty and that Garmin simply removed the option
instead of fixing it. Or maybe it comes only with specific devices or with special
maps ?

Gerd


> Date: Wed, 19 Aug 2015 12:04:41 +0200
> From: ***@suse.de
> To: mkgmap-***@lists.mkgmap.org.uk
> Subject: Re: [mkgmap-dev] What's the meaning of the 'has no region' warnings?
>
>
> Hi,
>
> On Wed, Aug 19, Gerd Petermann wrote:
>
> > I still have no idea where the data is used. Maybe the device shows some additional
> > info when you drive on a motorway.
> > When Mark Burton committed the code with r984 he did not describe the wanted effect,
> > but he also seemed to be unsure about its positive effects, see here:
> > http://www.mkgmap.org.uk/websvn/listing.php?repname=mkgmap&rev=984
> >
> > and here:
> > http://www.mkgmap.org.uk/pipermail/mkgmap-dev/2009q1/001293.html
>
> It looks like this is the code responsible for exit:to and similar variables.
> I played with this some time ago and the informations are shown in mapsource,
> don't remember anymore about my GPS device.
> The problem is, with the current way how things are mapped
> in OSM, it is nearly impossible to fill out this fields correct
> only with a style file. This would need help of mkgmap itself.
> That's why I stopped looking at it.
>
> But I haven't found a way to search for them, too.
>
> In the end, I would let the code stay and not remove it.
>
> Thorsten
>
> --
> Thorsten Kukuk, Senior Architect SLES & Common Code Base
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-***@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
Loading...